Repository navigation
bridge: add a dedicated lock to avoid concurrent run - #1674
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
MichaelMure
force-pushed
the
bridge-lock
branch
from
October 6, 2026 14:34
5116296 to
0cae455
Compare
MichaelMure
force-pushed
the
bridge-lock
branch
from
October 15, 2026 20:47
0cae455 to
b775b41
Compare
| } | ||
|
|
||
| go func() { | ||
| defer close(out) |
There was a problem hiding this comment.
When a Launchpad pull is cancelled after SearchTasks returns, closing this channel lets the relay finish without receiving an error event. It then records lastImportTime, and the CLI reports a completed import even though some tasks were not processed. This makes it harder to tell that the pull stopped early and may cause later pulls to resume from the wrong checkpoint.
MichaelMure
force-pushed
the
bridge-lock
branch
from
October 15, 2026 20:59
b775b41 to
2aa700e
Compare
MichaelMure
enabled auto-merge
October 15, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR appears safe to merge; the remaining cancellation-reporting issue is non-blocking.Findings
Summary
Adds a repository-wide
bridge.lockso bridge imports and exports cannot run together.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Import or export] --> B{Create bridge.lock} B -->|Already exists| C[Return ErrBridgeRunning] B -->|Created| D[Configure and initialize] D -->|Error| E[Remove lock and return error] D -->|Ready| F[Run bridge and relay events] F --> G[Event stream ends] G --> H[Remove lock and close output]Reviews (4) · Last reviewed commit: "bridge: add a dedicated lock to avoid co..." · Reviewed by Greptile