Skip to content

github: try to make token generation more robust against bad connection #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MichaelMure wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

github: try to make token generation more robust against bad connection #1045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
github: try to make token generation more robust against bad connection
  • Loading branch information
@MichaelMure
MichaelMure committed Mar 9, 2023
commit a30bd7ea2595ad529551df944996c0480eb12885
12 changes: 9 additions & 3 deletions bridge/github/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,9 @@ func pollGithubForAuthorization(deviceCode string, intervalSec int64) (string, e
for {
resp, err := client.PostForm("https://github.com/login/oauth/access_token", params)
if err != nil {
return "", errors.Wrap(err, "error polling the Github API")
fmt.Printf("error polling the Github API: %s\n", err)
time.Sleep(interval * time.Millisecond)
continue
}
if resp.StatusCode != http.StatusOK {
_ = resp.Body.Close()
Expand All @@ -287,13 +289,17 @@ func pollGithubForAuthorization(deviceCode string, intervalSec int64) (string, e
data, err := ioutil.ReadAll(resp.Body)
if err != nil {
_ = resp.Body.Close()
return "", errors.Wrap(err, "error polling the Github API")
fmt.Printf("error polling the Github API: %s\n", err)
time.Sleep(interval * time.Millisecond)
continue
}
_ = resp.Body.Close()

values, err := url.ParseQuery(string(data))
if err != nil {
return "", errors.Wrap(err, "error decoding Github API response")
fmt.Printf("error decoding Github API response: %s\n", err)
time.Sleep(interval * time.Millisecond)
continue
}

if token := values.Get("access_token"); token != "" {
Expand Down