Conversation
…ribute The `adjustTransactionDuration` handler set a `maxTransactionDurationExceeded` span-data flag alongside the `deadline_exceeded` status. The flag is a leftover from the old `@sentry/tracing` `maxTransactionDuration` option, which upstream replaced with `finalTimeout` in v7 (getsentry/sentry-javascript#5044). Nothing consumes it: no references in sentry, relay, or current sentry-javascript, and `@sentry/core` already records the modern equivalent (`sentry.idle_span_finish_reason: "finalTimeout"`) when the idle span times out. Drop the dead attribute. The `deadline_exceeded` status and both duration guards are unchanged; tests still assert the status. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
antonis
marked this pull request as ready for review
October 1, 2026 13:50
Comment on lines
92
to
-96
|
|
||
| if (isOutdatedTransaction) { | ||
| span.setStatus({ code: SPAN_STATUS_ERROR, message: 'deadline_exceeded' }); | ||
| // TODO: check where was used, might be possible to delete | ||
| span.setAttribute('maxTransactionDurationExceeded', 'true'); |
Collaborator
There was a problem hiding this comment.
Won't this be a break change with users alert filters?
Collaborator
|
if we decide to keep it as a minor, we should add a field on the changelog about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
adjustTransactionDuration(onSpanEndUtils.ts) set amaxTransactionDurationExceededspan-data flag alongside thedeadline_exceededstatus. This removes the flag (and the stale// TODO: check where was used, might be possible to deletenext to it). Thedeadline_exceededstatus and both duration guards (diff < 0, recorded-duration-exceeds-finalTimeout) are unchanged.💡 Motivation and Context
The flag is a leftover from the old
@sentry/tracingmaxTransactionDurationoption, which upstream replaced withfinalTimeoutin v7 (getsentry/sentry-javascript#5044). It only survives in archived@sentry/tracingmirrors.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps