ref(flask): Drop send_default_pii support - #7832
Open
pabloDeputter wants to merge 2 commits into
Open
pabloDeputter wants to merge 2 commits into
pabloDeputter wants to merge 2 commits into
Conversation
pabloDeputter
commented
Oct 2, 2026
| login_manager = LoginManager() | ||
| login_manager.init_app(app) | ||
|
|
||
| # install `LoginManager` with user loader to avoid Flask-Login's |
Member
Author
There was a problem hiding this comment.
Otherwise data_collection={} would resolve to {"user_info": True} meaning that it will try to access flask_login.current_user and raise an exception.
We could also do data_collection={"user_info": False} for all tests except test_flask_login_not_configured and test_flask_login_partially_configured
pabloDeputter
marked this pull request as ready for review
October 2, 2026 11:37
Contributor
Codecov Results 📊✅ 57276 passed | ⏭️ 2727 skipped | Total: 60003 | Pass Rate: 95.46% | Execution Time: 160m 60s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2078 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.34% 90.03% -0.31%
==========================================
Files 202 185 -17
Lines 26551 20849 -5702
Branches 9856 7234 -2622
==========================================
+ Hits 23988 18771 -5217
- Misses 2563 2078 -485
- Partials 1487 1207 -280Generated by Codecov Action |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
send_default_piisupport from Flask.Issues
Resolves #7590