ref(gcp)!: Drop send_default_pii support in request data collection - #7822
Open
ericapisani wants to merge 1 commit into
Open
ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Always route the query string and request body through `data_collection` instead of falling back to `send_default_pii` when `data_collection` is not configured. Update tests to drive behaviour through `data_collection` only. Fixes PY-2820 Fixes #7591
Contributor
Codecov Results 📊✅ 58218 passed | ⏭️ 2727 skipped | Total: 60945 | Pass Rate: 95.53% | Execution Time: 163m 18s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ❌ Patch coverage is 11.11%. Project has 2045 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.34% 90.19% -0.15%
==========================================
Files 202 185 -17
Lines 26551 20852 -5699
Branches 9856 7234 -2622
==========================================
+ Hits 23988 18807 -5181
- Misses 2563 2045 -518
- Partials 1487 1204 -283Generated by Codecov Action |
sentrivana
approved these changes
Oct 2, 2026
pabloDeputter
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always route the query string and request body through
data_collectioninstead of falling back to
send_default_piiwhendata_collectionis notconfigured.
Update tests to drive behaviour through
data_collectiononly.Fixes PY-2820
Fixes #7591