Skip to content

Add missing context kwarg to _sentry_task_factory #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 14 commits into from
Aug 28, 2023
Merged

Add missing context kwarg to _sentry_task_factory #2267

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e87512c
Add missing context kwargs to _sentry_task_factory
JohnnyDeuss Jul 21, 2023
74ce08a
Forward context to Task
JohnnyDeuss Jul 21, 2023
c765e34
Update _sentry_task_factory type comment
JohnnyDeuss Jul 21, 2023
bf7dfbe
Merge branch 'master' into fix-asyncio-task-factory
szokeasaurusrex Aug 16, 2023
554803c
Added type annotations and unit tests
szokeasaurusrex Aug 17, 2023
60cac88
Suppress linter error
szokeasaurusrex Aug 17, 2023
9b486c7
Merge branch 'master' into fix-asyncio-task-factory
szokeasaurusrex Aug 17, 2023
cf902d9
Fix import error in old Python versions
szokeasaurusrex Aug 17, 2023
067b8ea
Fix again linter error
szokeasaurusrex Aug 17, 2023
165e7ed
Fixed all mypy errors for real
szokeasaurusrex Aug 18, 2023
c04a1d0
Fix tests for Python 3.7
szokeasaurusrex Aug 18, 2023
40a8e3c
Merge branch 'master' into fix-asyncio-task-factory
szokeasaurusrex Aug 18, 2023
bd3d019
Add pytest.mark.forked to prevent threading test failure
szokeasaurusrex Aug 18, 2023
c6eee0c
Merge branch 'master' into fix-asyncio-task-factory
szokeasaurusrex Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add missing context kwargs to _sentry_task_factory
  • Loading branch information
@JohnnyDeuss
JohnnyDeuss committed Jul 21, 2023
commit e87512c6f0ea0febcb94ef5cc0259791dcac4086
4 changes: 2 additions & 2 deletions sentry_sdk/integrations/asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def patch_asyncio():
loop = asyncio.get_running_loop()
orig_task_factory = loop.get_task_factory()

def _sentry_task_factory(loop, coro):
def _sentry_task_factory(loop, coro, **kwargs):
# type: (Any, Any) -> Any

async def _coro_creating_hub_and_span():
Expand All @@ -56,7 +56,7 @@ async def _coro_creating_hub_and_span():

# Trying to use user set task factory (if there is one)
if orig_task_factory:
return orig_task_factory(loop, _coro_creating_hub_and_span())
return orig_task_factory(loop, _coro_creating_hub_and_span(), **kwargs)

# The default task factory in `asyncio` does not have its own function
# but is just a couple of lines in `asyncio.base_events.create_task()`
Expand Down