Skip to content

ref(core): Use SENTRY_OP convention constant - #24982

Open
nicohrubec wants to merge 2 commits into
developfrom
feat/sentry-op-conventions
Open

ref(core): Use SENTRY_OP convention constant#24982
nicohrubec wants to merge 2 commits into
developfrom
feat/sentry-op-conventions

Conversation

@nicohrubec

@nicohrubec nicohrubec commented Oct 2, 2026

Copy link
Copy Markdown
Member

Uses SENTRY_OP from @sentry/conventions/attributes throughout SDK instrumentation and tests. It is an exact replacement for sentry.op; emitted values, attribute precedence, and serialization remain unchanged.

Deprecates the existing core constant while preserving its public export and SDK re-exports for backward compatibility.

Part of #24961 / JS-3868.

@nicohrubec nicohrubec mentioned this pull request Oct 2, 2026
Closed
@github-actions

github-actions Bot commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.52 kB +0.02% +4 B 🔺
@sentry/browser - with treeshaking flags 27.68 kB -0.02% -4 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 27.57 kB +0.01% +1 B 🔺
@sentry/browser (incl. Tracing) 51.42 kB -0.05% -25 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 51.44 kB -0.05% -24 B 🔽
@sentry/browser (incl. Tracing, Profiling) 54.44 kB -0.03% -15 B 🔽
@sentry/browser (incl. Tracing, Replay) 91.03 kB -0.02% -14 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.03 kB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 95.73 kB -0.01% -9 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 108.68 kB -0.03% -26 B 🔽
@sentry/browser (incl. Feedback) 47.02 kB -0.04% -18 B 🔽
@sentry/browser (incl. sendFeedback) 34.58 kB +0.02% +5 B 🔺
@sentry/browser (incl. FeedbackAsync) 39.68 kB -0.02% -4 B 🔽
@sentry/browser (incl. Metrics) 30.53 kB -0.01% -3 B 🔽
@sentry/browser (incl. Logs) 30.82 kB -0.01% -3 B 🔽
@sentry/browser (incl. Metrics & Logs) 31.47 kB -0.03% -9 B 🔽
@sentry/react 31.36 kB -0.03% -8 B 🔽
@sentry/react (incl. Tracing) 53.78 kB -0.05% -23 B 🔽
@sentry/vue 37.49 kB -0.06% -20 B 🔽
@sentry/vue (incl. Tracing) 54.34 kB +0.02% +7 B 🔺
@sentry/svelte 29.55 kB -0.02% -3 B 🔽
@sentry/remix (Remix 3 client bundle) 55.76 kB -0.03% -16 B 🔽
CDN Bundle 31.22 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing) 51.98 kB +0.01% +2 B 🔺
CDN Bundle (incl. Logs, Metrics) 33.46 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 53.92 kB +0.01% +3 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.21 kB +0.01% +3 B 🔺
CDN Bundle (incl. Tracing, Replay) 89.54 kB -0.02% -16 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.51 kB -0.03% -24 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 95.72 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.71 kB -0.01% -1 B 🔽
CDN Bundle - uncompressed 92.14 kB - -
CDN Bundle (incl. Tracing) - uncompressed 154.49 kB -0.01% -6 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.71 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 160.44 kB -0.01% -6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 228.28 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 274.22 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 280.16 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.92 kB -0.01% -6 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.85 kB -0.01% -6 B 🔽
@sentry/nextjs (client) 56.31 kB -0.02% -8 B 🔽
@sentry/sveltekit (client) 51.85 kB -0.04% -18 B 🔽
@sentry/core/server 40.58 kB -0.03% -10 B 🔽
@sentry/core/browser 13.63 kB +0.01% +1 B 🔺
@sentry/node 144.72 kB -0.01% -7 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.2 kB - -
@sentry/node - without tracing 93.29 kB -0.01% -3 B 🔽
@sentry/node - without channel injection 122.96 kB +0.01% +1 B 🔺
@sentry/aws-serverless 101.56 kB -0.01% -2 B 🔽
@sentry/cloudflare (withSentry) - minified 208.6 kB -0.01% -16 B 🔽
@sentry/cloudflare (withSentry) 517.23 kB -0.04% -178 B 🔽

View base workflow run

@nicohrubec
nicohrubec force-pushed the feat/sentry-op-conventions branch from 815347e to cad3ee8 Compare October 2, 2026 11:28
@nicohrubec @codex
ref(core): Use SENTRY_OP convention constant
1750b89 
Co-Authored-By: GPT-6 <codex@openai.com>
@nicohrubec
nicohrubec force-pushed the feat/sentry-op-conventions branch from cad3ee8 to 1750b89 Compare October 2, 2026 11:59
@nicohrubec @codex
ref(core): Use SENTRY_OP in E2E fixtures
5dffe59 
Co-Authored-By: GPT-6 <codex@openai.com>
@nicohrubec
nicohrubec marked this pull request as ready for review October 2, 2026 12:08
@nicohrubec
nicohrubec requested review from a team as code owners October 2, 2026 12:08
@nicohrubec
nicohrubec requested review from Lms24, andreiborza, chargome, isaacs, logaretm and s1gr1d and removed request for a team October 2, 2026 12:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chargome chargome Awaiting requested review from chargome chargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@andreiborza andreiborza Awaiting requested review from andreiborza andreiborza is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@logaretm logaretm Awaiting requested review from logaretm logaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicohrubec