Skip to content

test(cloudflare): Widen the wrangler readiness retry window in integration tests - #24925

Open
mydea wants to merge 1 commit into
developfrom
test/cloudflare-cache-client-dedupe-flake
Open

mydea wants to merge 1 commit into
developfrom
test/cloudflare-cache-client-dedupe-flake

Conversation

@mydea

@mydea mydea commented Oct 1, 2026

Copy link
Copy Markdown
Member

cache-client > cacheClient: true - dedupe drops the same error across invocations failed on CI on its very first request: wrangler had reported "Ready", but the request still got 500s for the whole ~5s retry budget in fetchWithRetry. wrangler printed no error for it, so it's the known "ready but not serving yet" startup race (#20994, #22083), not a failure in the worker.

This widens the budget to ~15s. Requests that are expected to fail already disable retries, so the only cost is that a genuinely unexpected 500 takes longer to report, which is fine within the 60s test timeout. The "expected to succeed" error now also includes the response body: CI never showed what the 500 actually was, and this makes the next occurrence diagnosable instead of us widening the window again blindly.

🤖 Generated with Claude Code

…ation tests

The `cache-client` dedupe test failed on its very first request after ~5s of
500s: wrangler had reported "Ready" but could not serve the Durable Object RPC
yet. The retry budget was last widened to ~5s for the same race; give it ~15s,
and include the response body when a request unexpectedly fails so the next
occurrence shows what wrangler returned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea marked this pull request as ready for review October 1, 2026 10:44
@mydea
mydea requested a review from a team as a code owner October 1, 2026 10:44
@mydea
mydea requested review from JPeer264 and isaacs and removed request for a team October 1, 2026 10:44

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants