Skip to content

fix(node): Ensure status is correct for http server span errors #12477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
Jun 12, 2024
Merged

fix(node): Ensure status is correct for http server span errors #12477

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aa1f99
fix(node): Ensure status is correct for http server span errors
mydea Jun 12, 2024
925c844
add unit test
mydea Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add unit test
  • Loading branch information
@mydea
mydea committed Jun 12, 2024
commit 925c8443656ad182b2b9719a1df120b8683e61a4
13 changes: 13 additions & 0 deletions packages/opentelemetry/test/utils/mapStatus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,19 @@ describe('mapStatus', () => {
expect(mapStatus(span)).toEqual({ code: SPAN_STATUS_ERROR, message: 'invalid_argument' });
});

it('returns error status when span already has error status without message', () => {
const span = createSpan();
span.setStatus({ code: 2 }); // ERROR
expect(mapStatus(span)).toEqual({ code: SPAN_STATUS_ERROR, message: 'unknown_error' });
});

it('infers error status form attributes when span already has error status without message', () => {
const span = createSpan();
span.setAttribute(SEMATTRS_HTTP_STATUS_CODE, 500);
span.setStatus({ code: 2 }); // ERROR
expect(mapStatus(span)).toEqual({ code: SPAN_STATUS_ERROR, message: 'internal_error' });
});

it('returns unknown error status when code is unknown', () => {
const span = createSpan();
span.setStatus({ code: -1 as 0 });
Expand Down