Skip to content

feat(micrometer): [Micrometer 2] Add passive meter polling #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 4 commits into
base: feat/micrometer-active-meters
Choose a base branch
from
Draft

feat(micrometer): [Micrometer 2] Add passive meter polling #6114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
170c0a5
feat(micrometer): [Micrometer 2] Add passive meter polling
adinauer Sep 15, 2026
b18dce6
merge: Update Micrometer stack
adinauer Sep 17, 2026
47cf8d9
merge: Update Micrometer stack
adinauer Sep 18, 2026
54b12af
merge: Update Micrometer stack
adinauer Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
merge: Update Micrometer stack 
Carry active meter removal handling forward and use the shared removal lifecycle for function counters.

Co-Authored-By: Claude <noreply@anthropic.com>
  • Loading branch information
@adinauer @claude
adinauer and claude committed Sep 18, 2026
commit 54b12afdc0c71ba152161c81aebd5aa144a3f6d1
6 changes: 4 additions & 2 deletions sentry-micrometer/src/main/java/io/sentry/micrometer/SentryFunctionCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import java.util.function.ToDoubleFunction;
import org.jetbrains.annotations.NotNull;

final class SentryFunctionCounter<T> extends CumulativeFunctionCounter<T> {
final class SentryFunctionCounter<T> extends CumulativeFunctionCounter<T>
implements SentryRemovableMeter {
private final @NotNull SentryMeterRegistry registry;
private final @NotNull SentryMetricInfo metricInfo;
private volatile boolean removed;
Expand Down Expand Up @@ -42,7 +43,8 @@ void poll() {
}
}

void markRemoved() {
@Override
public void markRemoved() {
removed = true;
}
}
4 changes: 2 additions & 2 deletions sentry-micrometer/src/main/java/io/sentry/micrometer/SentryMeterRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ private void publishLongTaskTimer(final @NotNull LongTaskTimer timer) {
}

private void onMeterRemoved(final @NotNull Meter meter) {
if (meter instanceof SentryFunctionCounter) {
((SentryFunctionCounter<?>) meter).markRemoved();
if (meter instanceof SentryRemovableMeter) {
((SentryRemovableMeter) meter).markRemoved();
}
}

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.