Skip to content

Fix ball collisions with walls and paddle #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShadowLordAlpha wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ball collisions with walls and paddle #73

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd97e84
Correct Lower Paddle Collision
ShadowLordAlpha Nov 21, 2024
e049f0a
Fix Ball collision with walls
ShadowLordAlpha Nov 21, 2024
ab54e14
Correct Ball collision with Paddle
ShadowLordAlpha Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Correct Lower Paddle Collision 
When colliding with the lower wall the paddle would incorrectly go to far before stopping. This fixes the order of operations to correct when the paddle stops
  • Loading branch information
@ShadowLordAlpha
ShadowLordAlpha authored Nov 21, 2024
commit cd97e8432e4c802cf642da3f98bbc3c8fdc0805a
4 changes: 2 additions & 2 deletions Chapter01/Game.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ void Game::UpdateGame()
{
mPaddlePos.y = paddleH/2.0f + thickness;
}
else if (mPaddlePos.y > (768.0f - paddleH/2.0f - thickness))
else if (mPaddlePos.y > (768.0f - (paddleH/2.0f - thickness)))
{
mPaddlePos.y = 768.0f - paddleH/2.0f - thickness;
mPaddlePos.y = 768.0f - (paddleH/2.0f - thickness);
}
}

Expand Down