Skip to content

Warns when package is pinned #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Aug 23, 2015
Merged

Warns when package is pinned #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Warns when package is pinned
  • Loading branch information
@mrinaldi
mrinaldi committed Aug 19, 2015
commit 493949f0d6cce8b6439e3fd148a5bb9d37c6a844
17 changes: 16 additions & 1 deletion src/Paket.Core/PackageResolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,22 @@ let Resolve(getVersionsF, getPackageDetailsF, globalFrameworkRestrictions, rootD
exploredPackages.[(normalizedPackageName,version)] <- package
package
| _ -> package
| false,_ ->
| false,_ ->
let getPinnedVersion d =
match d.Parent with
| DependenciesFile _ ->
match d.VersionRequirement.Range with
| Specific v -> Some v
| OverrideAll v -> Some v
| _ -> None
| Package _ -> None
requirements
|> Set.filter (fun r -> NormalizedPackageName dependency.Name = NormalizedPackageName r.Name)
|> Set.map getPinnedVersion
|> Seq.choose id
|> Seq.tryHead
|> Option.iter (traceWarnfn " %O is pinned to version %O" dependency.Name)

tracefn " - %s %A" name version
let packageDetails : PackageDetails = getPackageDetailsF dependency.Sources dependency.Name version
let restrictedDependencies = DependencySetFilter.filterByRestrictions (dependency.Settings.FrameworkRestrictions @ globalFrameworkRestrictions) packageDetails.DirectDependencies
Expand Down