Skip to content

Handle dynamic OutputPath #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 7 commits into from
Aug 23, 2015
Merged

Handle dynamic OutputPath #942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f926f60
Add helper getChildNodes for XmlNode.ChildNodes
allykzam Jul 25, 2015
c0fb1c4
Replaced body of ProjectFile.GetOutputDirectory
allykzam Jul 25, 2015
ab605b8
Add body of ProjectFile.GetOutputDirectory.processPlaceholders
allykzam Jul 26, 2015
6602426
Use placeholders in fsprojtest OutputPath nodes
allykzam Jul 26, 2015
89ed879
Use all three project file samples in OutputPath test
allykzam Jul 26, 2015
d2b731f
Add parsing and handling of MSBuild conditions
allykzam Aug 20, 2015
dc79f6f
Update ProjectFile.GetOutputDirectory to use given build configuration
allykzam Aug 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use placeholders in fsprojtest OutputPath nodes 
Rather than using hard-coded values for the OutputPath, use
placeholders, so that their handling is tested as well.

Project1.fsprojtest contains a single OutputPath node to be used for
all build configurations, and should succeed so long as the placeholder
replacement is working correctly.

Project2.fsprojtest uses a hard-coded OutputPath node for all build
configurations, and keeps hard-coded OutputPath nodes for each
individual build configuration. This should succeed if the node
condition checking is working correctly.

Project3.fsprojtest keeps the traditional hard-coded OutputPath nodes
for each individual build configuration, and should succeed if the node
condition checking is working correctly.
  • Loading branch information
@allykzam
allykzam committed Jul 26, 2015
commit 6602426c408bb94f5d5ee77ab1b6cf6e4c04a611
3 changes: 1 addition & 2 deletions tests/Paket.Tests/ProjectFile/TestData/Project1.fsprojtest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
<TargetFrameworkProfile />
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
<RestorePackages>true</RestorePackages>
<OutputPath>bin\$(Configuration)\</OutputPath>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<Tailcalls>false</Tailcalls>
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<WarningLevel>3</WarningLevel>
<DocumentationFile>bin\Debug\fsharp_project_scaffold_tests.XML</DocumentationFile>
Expand All @@ -35,7 +35,6 @@
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<Tailcalls>true</Tailcalls>
<OutputPath>bin\Release\</OutputPath>
<DefineConstants>TRACE</DefineConstants>
<WarningLevel>3</WarningLevel>
<DocumentationFile>bin\Release\Paket.Tests.xml</DocumentationFile>
Expand Down
1 change: 1 addition & 0 deletions tests/Paket.Tests/ProjectFile/TestData/Project2.fsprojtest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<TargetFrameworkProfile />
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
<RestorePackages>true</RestorePackages>
<OutputPath>bin\Fail\</OutputPath>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down