Skip to content

settings for dependent packages should be respected - #919

Merged
forki merged 1 commit into
fsprojects:masterfrom
baronfel:thread_through_settings_on_dependencies
Jul 13, 2015
Merged

forki merged 1 commit into
fsprojects:masterfrom
baronfel:thread_through_settings_on_dependencies

Conversation

@baronfel

@baronfel baronfel commented Jul 8, 2015

Copy link
Copy Markdown
Contributor

Consider a paket.dependencies file:

source api.nuget.org/etc/etc

nuget A
nuget B content: none

and a paket.references file in a project that just specifies a dependency on A

Now imagine that B is a dependency of A

Right now on install for a project we take the full set of packages [A,B] and extract from it the top-level dependencies of the project, resulting in [A]. We then configure the installSettings for this dependency, which in this case is the empty InstallSettings.

After we build the top-level map we augment it with the n-tier dependencies of each top-level dependency, and use the parent's configured InstallSettings only. This results in an install of package B where the content: none directive is not honored.

This pull request resolves the settings for the n-tier dependencies in a similar manner to the top-level dependencies, while allowing any top-level dependency settings to override the settings configured for the lower-level package if any are present.

@forki

forki commented Jul 13, 2015

Copy link
Copy Markdown
Member

very cool thx.

forki added a commit that referenced this pull request Jul 13, 2015
…ndencies

settings for dependent packages should be respected
@forki
forki merged commit 8612713 into fsprojects:master Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants