Repository navigation
settings for dependent packages should be respected - #919
Merged
forki merged 1 commit intoJul 13, 2015
Merged
Conversation
Member
|
very cool thx. |
forki
added a commit
that referenced
this pull request
Jul 13, 2015
…ndencies settings for dependent packages should be respected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider a paket.dependencies file:
and a paket.references file in a project that just specifies a dependency on A
Now imagine that B is a dependency of A
Right now on install for a project we take the full set of packages [A,B] and extract from it the top-level dependencies of the project, resulting in [A]. We then configure the installSettings for this dependency, which in this case is the empty InstallSettings.
After we build the top-level map we augment it with the n-tier dependencies of each top-level dependency, and use the parent's configured InstallSettings only. This results in an install of package B where the content: none directive is not honored.
This pull request resolves the settings for the n-tier dependencies in a similar manner to the top-level dependencies, while allowing any top-level dependency settings to override the settings configured for the lower-level package if any are present.