Skip to content

Rewrite template file parsing - #660

Merged
forki merged 1 commit into
fsprojects:masterfrom
mavnn:master
Feb 26, 2015
Merged

forki merged 1 commit into
fsprojects:masterfrom
mavnn:master

Conversation

@mavnn

@mavnn mavnn commented Feb 26, 2015

Copy link
Copy Markdown
Contributor

Closes #625 and tests for #659

Before:

before

After:

after

It would be easier to smug about the two order of magnitude improvement if I hadn't written the original :)

@tpetricek

Copy link
Copy Markdown
Member

It runs so fast that the colors don't even start fading out :-)

@mavnn

mavnn commented Feb 26, 2015

Copy link
Copy Markdown
Contributor Author

@tpetricek ha :). I rebuilt before realising I wanted a benchmark!

@theimowski

Copy link
Copy Markdown
Member

Nice!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay one custom operator less. ❤️

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new one to ensure balance in the force.

forki added a commit that referenced this pull request Feb 26, 2015
Rewrite template file parsing
@forki
forki merged commit d8e5c54 into fsprojects:master Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template file parser is fragile and very inefficient

5 participants