Skip to content

Unescape library filename #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 2 commits into from
Dec 1, 2014
Merged

Unescape library filename #412

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a6870a
decode uri on createRelativePath
theimowski Dec 1, 2014
2eabf1c
unescape extracted file names from nupkg - references #411
theimowski Dec 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
unescape extracted file names from nupkg - references #411
  • Loading branch information
@theimowski
theimowski committed Dec 1, 2014
commit 2eabf1cffa6aa3004f8c11b6392bdaf62bffcf0a
3 changes: 3 additions & 0 deletions src/Paket.Core/NuGetV2.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,9 @@ let ExtractPackage(fileName:string, targetFolder, name, version:SemVerInfo) =
for e in zip do
try
e.Extract(targetFolder, ExtractExistingFileAction.OverwriteSilently)
let unescapedName = Uri.UnescapeDataString e.FileName
if unescapedName <> e.FileName then
File.Move(Path.Combine(targetFolder, e.FileName), Path.Combine(targetFolder, unescapedName))
with
| exn ->
failwithf "Error during unzipping %s in %s %A: %s" e.FileName name version exn.Message
Expand Down