Repository navigation
Use a different nuget extraction routine to extract to versioned folders - #4081
Merged
Merged
Conversation
Contributor
Author
|
definitely looks like there's some amount of lock contention happening as a result of this now, based on the test failures. |
Contributor
Author
|
cool, the only failing test is the same one that's failing in #4080, so if I can figure that out then we should be good to go. |
Contributor
Author
|
@smoothdeveloper do you have any ideas what might be causing the issue in this test recently? |
Contributor
|
@baronfel, no idea If you don't mind checking how it behaves locally, if it passes locally, I guess adjusting the print statement to output the expected and actual output will give us an indication on what's wrong on the integration machine. |
Member
|
what's the status here? |
Contributor
Author
|
Blocked by a failing test in the FSI handler, but this same test is failing in master as well so I'm not sure it's because of these changes. |
This was referenced Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4075 by using nuget APIs for extraction to versioned folders directly. I also integrated logging from nuget into our logging, but behind the verboseFn safeguards so as to not spam users.