Skip to content

Added BootstrapperOutputDir to config #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 4 commits into from
Nov 25, 2019
Merged

Added BootstrapperOutputDir to config #3733

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a30d9a8
Added BootstrapperOutputDir to config
Nov 24, 2019
7da2195
Added performance note to docs
Nov 24, 2019
fda7b94
Corrected tests to account for Unix filesystem
Nov 25, 2019
c74cd5d
Review fixes to docs
Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added performance note to docs
  • Loading branch information
Johny Woller Skovdal Johny Woller Skovdal
Johny Woller Skovdal authored and Johny Woller Skovdal committed Nov 24, 2019
commit 7da21951541469d2ff32d75ae43191689923c951
7 changes: 7 additions & 0 deletions docs/content/bootstrapper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,10 @@ A few default settings are applied:
* The bootstrapper is silenced and only errors are displayed. `-v` can be used
once to restore normal output or twice to show more details.
* If no version is specified a default `--max-file-age` of `12` hours is used.

**IMPORTANT PERFOMANCE NOTE:**

If you have aggresive Anti Virus monitoring, but have your development folder

@matthid matthid Nov 25, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aggressive?

@JohnyWS JohnyWS Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where it scans activity of processes in a non-excluded directory. Performance really suffers then if loads of files are created (which paket does a lot :) )

@JohnyWS JohnyWS Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, I agree, it could be worded differently, or even left out.

@matthid matthid Nov 25, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was taking about the typo ;)

@JohnyWS JohnyWS Nov 25, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the updated wording is better - as well as having fewer typos... ;)

excluded, then be aware that the temp folder will be impacted in Magic Mode.
To work around this, change the `BoostrapperOutputDir` to a folder that uses
a path inside the repo, and exclude that folder from git instead.