Skip to content

Fix #3410 - UnauthorizedAccessException writing to MyProject.paket.references.cached #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 7 commits into from
Sep 20, 2019
Merged

Fix #3410 - UnauthorizedAccessException writing to MyProject.paket.references.cached #3617

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
215256a
Add integration test to reproduce readonly file scenario in #3410
yaakov-h Jul 22, 2019
77bf907
Fix #3410 by marking file non-readonly before and after copying
yaakov-h Jul 22, 2019
9a174fa
Only mess with file-read-only-ness on Windows.
yaakov-h Jul 29, 2019
1bbc1fe
Manually create cached file, since obj folder is in gitignore
yaakov-h Jul 30, 2019
8c4c1ce
Bump CI
yaakov-h Aug 5, 2019
43413b2
Refresh file metadata before using it
yaakov-h Sep 19, 2019
eed76d4
Merge remote-tracking branch 'origin/master' into fix/3410-readonly-c…
yaakov-h Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refresh file metadata before using it
  • Loading branch information
@yaakov-h
yaakov-h committed Sep 19, 2019
commit 43413b2a41cc840861f9e2180d3a6886a8a22e2f
7 changes: 5 additions & 2 deletions src/Paket.Core/Installation/RestoreProcess.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,12 +504,15 @@ let createProjectReferencesFiles (lockFile:LockFile) (projectFile:ProjectFile) (
if File.Exists (referencesFile.FileName) then
// The existing cached file can be read-only if it was copied from a read-only file.
// For example, when using Team Foundation Version Control with Server workspaces.
if Utils.isWindows && paketCachedReferencesFileName.Exists && paketCachedReferencesFileName.IsReadOnly then
paketCachedReferencesFileName.IsReadOnly <- false
if Utils.isWindows then
paketCachedReferencesFileName.Refresh()
if paketCachedReferencesFileName.Exists && paketCachedReferencesFileName.IsReadOnly then
paketCachedReferencesFileName.IsReadOnly <- false

File.Copy(referencesFile.FileName, paketCachedReferencesFileName.FullName, true)

if Utils.isWindows then
paketCachedReferencesFileName.Refresh()
paketCachedReferencesFileName.IsReadOnly <- false
else
// it can happen that the references file doesn't exist if paket doesn't find one in that case we update the cache by deleting it.
Expand Down