Skip to content

fix multiple dotnet pack invocations with different Version property #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 3 commits into from
May 28, 2019
Merged

fix multiple dotnet pack invocations with different Version property #3585

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e572da
add failing test
enricosada May 24, 2019
2472b59
fix mutiple dotnet pack invocations with different Version property
enricosada May 24, 2019
cece905
cleanup
enricosada May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup
  • Loading branch information
@enricosada
enricosada committed May 24, 2019
commit cece905a9bd4256d76b72d69234271dd0397b4a8
10 changes: 2 additions & 8 deletions integrationtests/Paket.IntegrationTests/PackSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,6 @@ let ``#4003 dotnet pack of a global tool with p2p``() =
nuspec.Dependencies.Value.Length
|> shouldEqual 0


[<Test>]
let ``#4004 dotnet pack using different versions``() =
let project = "lib1"
Expand All @@ -748,7 +747,7 @@ let ``#4004 dotnet pack using different versions``() =

let rootPath = scenarioTempPath scenario

directPaket ("restore") scenario
directPaket "restore" scenario
|> ignore

let pack outDir additionalArgs expectedVersion =
Expand All @@ -758,17 +757,12 @@ let ``#4004 dotnet pack using different versions``() =
|> ignore

let nupkgPath = Path.Combine(outPath, sprintf "%s.%s.nupkg" project expectedVersion)
if File.Exists nupkgPath |> not then Assert.Fail(sprintf "Expected '%s' to exist" nupkgPath)
Assert.True(File.Exists nupkgPath, sprintf "Expected '%s' to exist" nupkgPath)

pack "out1" "" "1.0.0"
pack "out1" "/p:Version=1.2.3" "1.2.3"
pack "out2" "/p:Version=2.3.4" "2.3.4"






[<Test>]
let ``#4010-pack-template-only``() =
let scenario = "i004010-pack-template-only"
Expand Down