Repository navigation
improved restore speedup - #3512
Merged
Merged
Conversation
from origin (Merge pull request fsprojects#3323 from fsprojects/matthid-patch-1)
Contributor
|
Mutability for the win! |
Contributor
|
Better yet, profiling + judicious use of localized mutability 👍 Nice work @viktor-svub! |
Member
|
Cool. What abut the other 2 sets?
Am Do., 21. Feb. 2019, 18:17 hat Chet Husk <notifications@github.com>
geschrieben:
… Better yet, profiling + judicious use of localized mutability 👍 Nice
work @viktor-svub <https://github.com/viktor-svub>!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3512 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNADUyJNo2vEPr6zWpvv9260W-W6Iks5vPtSPgaJpZM4bH0OT>
.
|
Contributor
Author
|
Well, I could change them as well, but their operations did not light up under the profiler and I generally avoid touching working code -- using F# Set there does not hurt, so from my PoV it's the preferred way. I suspect the inherently expensive slow operation here is Set.map (which seems to always enforce re/creation of new set), and rest of the refactoring was only done to keep the code readable, as an attempt to replace just the map/filter and keep the rest semi-immutable did not end well. |
Member
|
ok thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi everyone and sorry for the long silence...
paket restore, specifically where way too many inter-connected dependencies are involved