Skip to content

Fix infinite recursion when handling errors. #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Jun 18, 2018
Merged

Fix infinite recursion when handling errors. #3251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix infinite recursion when handling errors. 
Fixes #3249.
  • Loading branch information
@yaakov-h
yaakov-h committed Jun 13, 2018
commit 4de76e56bfc7144f2ebbea81e44f1277a17aa8b0
4 changes: 2 additions & 2 deletions src/Paket.Core/Installation/RestoreProcess.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ let createProjectReferencesFiles (lockFile:LockFile) (projectFile:ProjectFile) (
if verbose then
tracefn " - %s already up-to-date" newFileName.FullName
with
| exn ->
| exn when trials > 0 ->
if verbose then
tracefn "Failed to save resolved file %s. Retry. Message: %s" newFileName.FullName exn.Message
System.Threading.Thread.Sleep(100)
Expand Down Expand Up @@ -421,7 +421,7 @@ let createProjectReferencesFiles (lockFile:LockFile) (projectFile:ProjectFile) (
// it can happen that the references file doesn't exist if paket doesn't find one in that case we update the cache by deleting it.
if paketCachedReferencesFileName.Exists then paketCachedReferencesFileName.Delete()
with
| exn ->
| exn when trials > 0 ->
if verbose then
tracefn "Failed to save cached file %s. Retry. Message: %s" paketCachedReferencesFileName.FullName exn.Message
System.Threading.Thread.Sleep(100)
Expand Down