Repository navigation
Add .NETCoreApp2.1 and UAP10.0.16300 tfms - #3094
Merged
forki merged 5 commits intoMar 1, 2018
Merged
Conversation
Member
|
the fix looks good, but still red integration tests. |
Contributor
Author
|
Yeah, I broke tests while trying to fix them, will look into it. |
sliepie
force-pushed
the
tfms-uap10.0.16300-netcoreapp2.1
branch
from
February 28, 2018 09:22
ee49c48 to
f2f503b
Compare
sliepie
force-pushed
the
tfms-uap10.0.16300-netcoreapp2.1
branch
from
February 28, 2018 09:24
f2f503b to
0d25690
Compare
Member
|
can you please merge master. that may fix couple of tests |
Contributor
Author
|
Integration tests are passing on local machine, except 1: |
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #3081
When restoring fake-bootstrap, errors were appearing about .NETCoreApp2.1 and UAP10.0.16300 TFMs
Added these TFMs to FrameworkHandling.fs and fixed broken tests. If more changes are needed, let me know