Skip to content

[API] add overload for Dependencies.Init - #3019

Merged
forki merged 3 commits into
fsprojects:masterfrom
enricosada:init_with_args
Jan 31, 2018
Merged

forki merged 3 commits into
fsprojects:masterfrom
enricosada:init_with_args

Conversation

@enricosada

Copy link
Copy Markdown
Contributor

add overload to Dependencies.Init to:

  • specify sources
  • choose if download bootstrapper
  • additional global config in deps

@matthid matthid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

|> returnOrFail
)

#if !NO_BOOTSTRAPPER

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know that flag?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that to disable boostrapper on .net core. was not working anyway, no need to download it

@forki
forki merged commit 9b244da into fsprojects:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants