Skip to content

Reduce next-link warning to once per method/endpoint, omitting the query, fixes #2848 #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 2 commits into from
Jan 18, 2018
Merged

Reduce next-link warning to once per method/endpoint, omitting the query, fixes #2848 #2994

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bee49e
Merge pull request #2 from fsprojects/master
viktor-svub Jan 18, 2018
ba482b8
next-link warning reduced to once per method/endpoint, omitting the q…
viktor-svub Nov 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
next-link warning reduced to once per method/endpoint, omitting the q… 
…uery, fixes #2848
  • Loading branch information
@viktor-svub
viktor-svub committed Jan 18, 2018
commit ba482b8868bcf274c440bb1e4e4a496b319b34c7
6 changes: 5 additions & 1 deletion src/Paket.Core/Dependencies/NuGetV2.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ let private followODataLink auth url =

match atLeastOneFailed with
| Some i ->
traceWarnfn "At least one 'next' link (index %d) returned a empty result (noticed on '%O'): ['%s']" i url (System.String.Join("' ; '", linksToFollow))
let mutable uri = null // warn once per apecific API endpoint, but try to cut the query

@forki forki Jan 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

let baseUrl = if Uri.TryCreate(url, UriKind.Absolute, &uri) then uri.AbsolutePath else url
traceWarnIfNotBefore baseUrl
"At least one 'next' link (index %d) returned a empty result (noticed on '%O'): ['%s']"
i url (System.String.Join("' ; '", linksToFollow))
| None -> ()
return
true,
Expand Down