Repository navigation
Use a hashset - #2853
Use a hashset#2853
Conversation
|
so from 21s down to 1s via 3 PRs - good team work @theimowski! |
|
LGTM, pity there are no tests to be sure there's no regression. |
|
@theimowski my question is: are we ver going back here? In my optimization we only add to the set and never reuse old sets. |
|
Hm crap you're right. Now it might skip some chains ... Then it would output just |
|
so revert? |
|
That's up to you - behavior changed, but I'm not sure whether it's ok or not. |
|
@matthid ? |
|
Do we know how does yarn handle such cases? |
|
Dunno. But I'm fine with revert. 3s is still usable. |
|
Ok then how about revert and create issue to cover the code with some tests and optionally then improve perf |
references #2844
brings original why sample down to 1s