Repository navigation
do not evaluate all templates with --template switch - #2769
Merged
Merged
Conversation
lexarchik
commented
Sep 18, 2017
| allTemplateFiles.Remove(templateFile'.FileName) |> ignore | ||
|
|
||
| let merged = merge buildConfig buildPlatform version specificVersions projectFile templateFile' | ||
| let merged = lazy (merge buildConfig buildPlatform version specificVersions projectFile templateFile') |
Contributor
Author
There was a problem hiding this comment.
Idea of this fix is here - make "dangerous" operation lazy.
So exception only occur if project will actually be needed for packing.
forki
reviewed
Sep 18, 2017
| [Oo]bj/ | ||
|
|
||
| # Enable scenarios in integration tests | ||
| !integrationtests/scenarios/*/before/** |
Contributor
Author
There was a problem hiding this comment.
As far as i understand, idea is - all files in "test-scenario/before" folder is "setup" for test.
I think it's slightly easier to remove .idea, .dotsettings etc from commit than add ignored dlls/pdbs.
Member
|
Thanks for taking care of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to fix #2765