Skip to content

Make packages folder optional #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthid merged 19 commits into from
Aug 26, 2017
Merged

Make packages folder optional #2638

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5bb0d58
Initial scetch in making the packages folder optional
matthid Aug 20, 2017
42a5b28
implement paket-file changes.
matthid Aug 20, 2017
e6b4076
create directory before downloading if it doesn't exist.
matthid Aug 20, 2017
2a681b8
check if file needs to be copied and replace if needed.
matthid Aug 20, 2017
926a246
add 'PackageInfo' to fallback to group settings automatically (for al…
matthid Aug 20, 2017
2be27a1
add some docs around the storage option.
matthid Aug 20, 2017
43a5658
garbage collector can ignore not existing directories
matthid Aug 20, 2017
31c28f3
some cleanup
matthid Aug 21, 2017
1efc73d
Merge remote-tracking branch 'origin/master' into packages_folder
matthid Aug 21, 2017
f5250f6
Merge branch 'master' of github.com:fsprojects/Paket into packages_fo…
matthid Aug 21, 2017
aa44580
Merge branch 'master' of github.com:fsprojects/Paket into packages_fo…
matthid Aug 21, 2017
518c918
Merge branch 'master' of github.com:fsprojects/Paket into packages_fo…
matthid Aug 25, 2017
48341bd
make isExtracted ignore any existing license files (this might be foo…
matthid Aug 26, 2017
27da527
more docs
matthid Aug 26, 2017
f151827
create directory if it doesn't exist
matthid Aug 26, 2017
d3d1c80
GetFullPath can throw
matthid Aug 26, 2017
38ba8b3
try to find the path which is too long...
matthid Aug 26, 2017
1b88f14
get rid of GetFullPath
matthid Aug 26, 2017
0911a8b
fix path too long in integration test
matthid Aug 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
garbage collector can ignore not existing directories
  • Loading branch information
@matthid
matthid committed Aug 20, 2017
commit 43a5658d7d7eeaabcf2d9d64000b395398e44e51
6 changes: 4 additions & 2 deletions src/Paket.Core/Installation/GarbageCollection.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ let discoverDirectExtractedPackages groupName groupPackagesDirectory : Extracted
| _ -> None

let findGroupPackages groupName (groupDir:DirectoryInfo) =
groupDir.GetDirectories()
|> Array.choose (packageInDir groupName)
if groupDir.Exists then
groupDir.GetDirectories()
|> Array.choose (packageInDir groupName)
else [||]

let packagesFolder = groupPackagesDirectory
findGroupPackages groupName packagesFolder
Expand Down