Skip to content

Don't change BOM for existing project files - fixes #2271 #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Aug 17, 2017
Merged

Don't change BOM for existing project files - fixes #2271 #2575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Paket.Core/PaketConfigFiles/ProjectFile.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,11 +1180,24 @@ module ProjectFile =


let save forceTouch project =
let determineEncoding fileName =
if File.Exists fileName then
let utf8WithBom = UTF8Encoding true
let bom = utf8WithBom.GetPreamble()
let bomBuffer = Array.zeroCreate bom.Length

use fs = new FileStream(fileName, FileMode.Open, FileAccess.Read)
fs.Read(bomBuffer, 0, bom.Length) |> ignore
if bomBuffer = bom then utf8WithBom else UTF8Encoding false
else UTF8Encoding false

if Utils.normalizeXml project.Document <> project.OriginalText || not (File.Exists(project.FileName)) then
if verbose then
verbosefn "Project %s changed" project.FileName
let encoding = determineEncoding project.FileName
use f = File.Open(project.FileName, FileMode.Create)
project.Document.Save(f)
use sw = new StreamWriter(f, encoding)
project.Document.Save(sw)
elif forceTouch then
File.SetLastWriteTimeUtc(project.FileName, DateTime.UtcNow)

Expand Down