Skip to content

show stack trace in verbose mode (closes #2480) - #2481

Merged
forki merged 4 commits into
fsprojects:masterfrom
Stift:fixVerboseOutput_
Jul 5, 2017
Merged

forki merged 4 commits into
fsprojects:masterfrom
Stift:fixVerboseOutput_

Conversation

@Stift

@Stift Stift commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

minimize the output in normal mode when getPackageDetails have a problem.
See #2480 for more info.

@forki

forki commented Jul 4, 2017

Copy link
Copy Markdown
Member

/cc @matthid

@matthid

matthid commented Jul 4, 2017

Copy link
Copy Markdown
Member

Oh I was too slow: #2480 (comment)
Please only handle the one particular instance of the error.

@matthid

matthid commented Jul 4, 2017

Copy link
Copy Markdown
Member

The reasoning is that I want to move away from all the general "with e ->" clauses thoughout the code base. but that is a painful process (so I kind of provoke people to open issues by printing stacktraces on errors, this was imho better than if I forgot something and introduced breaking changes)

@Stift

Stift commented Jul 4, 2017

Copy link
Copy Markdown
Contributor Author

I'll understand.
Updated it and limiting to IOException. Unfortunately a bunch of inherited classes are also now catched the same way (PathTooLong, etc.). Is this okay?

@matthid

matthid commented Jul 4, 2017

Copy link
Copy Markdown
Member

@Stift in a perfect world i'd like to only catch the access denied error, but I can see the difficulties here. So I'm fine with it. Maybe we can add a code comment to clarify why it was added (to make it easier for future contributors to handle the sub-types differently). A link to your issue is probably just fine.

@Stift

Stift commented Jul 4, 2017

Copy link
Copy Markdown
Contributor Author

I know, that perfect world I also dream of. I just wanted to prevent filtering on message strings and the exception does not give more details.

@matthid

matthid commented Jul 4, 2017

Copy link
Copy Markdown
Member

Yes I agree, filtering of the string is error prone. Thanks for looking into this.

@forki

forki commented Jul 5, 2017

Copy link
Copy Markdown
Member

thanks!

@forki
forki merged commit bb7caf0 into fsprojects:master Jul 5, 2017
@Stift
Stift deleted the fixVerboseOutput_ branch July 5, 2017 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants