Skip to content

Allow comments in the references file. - #2477

Merged
forki merged 1 commit into
fsprojects:masterfrom
fsoikin:issue_2371
Jul 1, 2017
Merged

forki merged 1 commit into
fsprojects:masterfrom
fsoikin:issue_2371

Conversation

@fsoikin

@fsoikin fsoikin commented Jun 30, 2017

Copy link
Copy Markdown
Contributor

Fixes #2371.

@forki

forki commented Jul 1, 2017

Copy link
Copy Markdown
Member

Cool!

@forki
forki merged commit 5dc3772 into fsprojects:master Jul 1, 2017
@fsoikin

fsoikin commented Jul 2, 2017

Copy link
Copy Markdown
Contributor Author

@forki note that this may become a breaking change under some very specific circumstances: before this, the removeComment function allowed comments to start anywhere, but now comments have to start either at the beginning of the line or after a space.

Also, I have realized that a comment can start after a space, but not after a tab. Do you think it would be a good idea to update it to allow tabs as well? Or perhaps anything that is Char.IsWhitespace?

@forki

forki commented Jul 2, 2017

Copy link
Copy Markdown
Member

Char.iswhitespace sounds good

@fsoikin

fsoikin commented Jul 2, 2017

Copy link
Copy Markdown
Contributor Author

Got it. #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants