Repository navigation
Check if references file exists on disk before installing into project file - #2224
Conversation
|
And, in addition, got your Travis CI build working again. 👍 |
|
@agross do you remember how we defined that case? If a csproj doesn't have a corresponding references file - should treat it as empy or do we ignore the project? |
|
@forki If a |
currently it's creating an empty references file in memory. So it does not install anything - but it touches it since it wants to clean. |
|
I wished you would not see there targets as a problem. It's the only solution to get netcore working. They might not work for you yet. but it's the important part that needs fixing. |
…nterferes with csproj: fsprojects/Paket#2224
Check if
paket.referencesfile exists on disk before allowing paket to blindly install/modify (csproj) project files with<Import>. Ifpaket.referencesis missing from a project directory, paket should not touch any project files.Also, according to @forki:
This is currently not true as there is no check here to exclude project files (
csprojs) from theFindAllProjectsenumeration. Additionally, this particular issue has caused some drama in issue #2029.This PR resolves the issue and makes sure that
paket.referencesexists on disk before paket does anything to MSBuild project files.Also resolves #2220 by providing a way to opt-out of the
<Import>mechanism.Thanks,
Brian
🍫 🍪 🍭 Ronald Jenkees - Stay Crunchy