Skip to content

Report broken project dependencies properly #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 1 commit into from
Jan 30, 2017
+17 −2
Merged

Report broken project dependencies properly #2131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/Paket.Core/InstallProcess.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ let inline private getOrAdd (key: 'key) (getValue: 'key -> 'value) (d: Dictionar
d.[key] <- value
value

// HashSet to prevent repeating the same "Broken project dependency" warning
let brokenDeps = HashSet<_>()

/// Applies binding redirects for all strong-named references to all app. and web.config files.
let private applyBindingRedirects isFirstGroup createNewBindingFiles redirects cleanBindingRedirects
root groupName findDependencies allKnownLibs
Expand All @@ -213,11 +216,23 @@ let private applyBindingRedirects isFirstGroup createNewBindingFiles redirects c
|> Option.map ReferencesFile.FromFile
referenceFiles |> getOrAdd projectFile referenceFile

let rec dependencies (projectFile : ProjectFile) =

let rec dependencies (projectFile : ProjectFile) =
let reportBrokenDep (src:string) (target:string) =
if brokenDeps.Add (src,target) then
traceWarnfn "Broken project dependency: '%s' -> '%s'" src target

match referenceFile projectFile with
| Some referenceFile ->
projectFile.GetInterProjectDependencies()
|> Seq.map (fun r -> projectCache |> getOrAdd r.Path ProjectFile.TryLoad)
|> Seq.map (fun r ->
let found = getOrAdd r.Path ProjectFile.TryLoad projectCache
match found with
| Some prj -> Some prj
| None ->
reportBrokenDep projectFile.FileName r.Path
None)

|> Seq.choose id
|> Seq.collect (fun p -> dependencyGraph |> getOrAdd p dependencies)
|> Seq.append (
Expand Down