Repository navigation
A fix proposal for - Convert from nuget: Local package source give false error #1794 - #2112
Merged
Merged
Conversation
Member
|
/cc @theimowski could you please review this? |
Member
|
Looks OK, wondering whether we could add this to normalizePath utility? Also can we get rid of changes in solution and project file? Those seem irrelevant |
Contributor
Author
|
Thanks for the feed back. Will move it to normalizePath utility and remove the changes in the solution and prject files. I was wondering about the changes that was introduced for testing on my computer. |
Member
|
thx! |
Contributor
Author
|
Good day Steffen
Thanks for accepting my proposal.
If you have more bugs that need fixing, please feel free to point me to them.
I like working with your code and I start to get the hang of it.
Regards
Johannes Vorster
T: (+27) 079 490 8706
F: (+27) 088 012 661 6672
E: johannes.vorster@outlook.com<mailto:elconi.johannes@gmail.com>
<http://za.linkedin.com/in/johannesv>
…________________________________
From: Steffen Forkmann <notifications@github.com>
Sent: 24 January 2017 01:03 PM
To: fsprojects/Paket
Cc: Johannes; Author
Subject: Re: [fsprojects/Paket] A fix proposal for - Convert from nuget: Local package source give false error #1794 (#2112)
Merged #2112<#2112>.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2112 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFqcIRf1nLzQZ0ROo42DjxhWmaFhUTEvks5rVdp-gaJpZM4Lmfau>.
|
Member
|
Cool and welcome. Basically all open issues are available for all contributors. Some are really challenging and others are much easier. It's hard to tell sometimes without trying ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to track down the error I was getting on my computer for issue #1794.
The problem was that the path string that was pass to the Directory.Exists function had double quotes at the start and beginning.
I tested it on a Windows 10 computer, but was able to test it on a linux computer because of issue #1809 : Install problem recurred in Ubuntu.
I don't have access to a ios computer.
I hope it help.