Repository navigation
Make config writer use XmlWriter for disk write - #2110
Merged
Merged
Conversation
... instead of doing XmlWriter -> string -> disk. - This guarantees that the file encoding and the XML declaration are properly in sync. - Adds a `saveNormalizedXml` function to Utils to facilitate this. - Adds a test to UtilsSpecs for the new function. - Updates ConfigFile.saveConfigNode to use the new function. - Should fix fsprojects#2003 permanently. - Removes the previous fix in commit d1d06b7
Member
|
cool. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of doing XmlWriter -> string -> disk.
properly in sync.
saveNormalizedXmlfunction to Utils to facilitate this.