Skip to content

Ensure stable ordering of references in the same ItemGroup - #2105

Merged
forki merged 3 commits into
fsprojects:masterfrom
ZapTechnology:master
Jan 6, 2017
Merged

forki merged 3 commits into
fsprojects:masterfrom
ZapTechnology:master

Conversation

@flin-8

@flin-8 flin-8 commented Jan 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@forki

forki commented Jan 6, 2017

Copy link
Copy Markdown
Member

It looks like you need to fix the tests

@forki

forki commented Jan 6, 2017

Copy link
Copy Markdown
Member

what was the error that lead to this?

@flin-8

flin-8 commented Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

There were no errors, but we have a large c# solution, and every time we add a paket dependency to one of the projects and run "paket install", many of the other csproj files that have no dependency changes would have their references reordered

@forki

forki commented Jan 6, 2017

Copy link
Copy Markdown
Member

Interesting. I wonder why that would happen.

@forki
forki merged commit 2ab6f63 into fsprojects:master Jan 6, 2017
@flin-8

flin-8 commented Jan 7, 2017

Copy link
Copy Markdown
Contributor Author

Sorry it doesn't happen every time we add a paket dependency. it's probably quite niche, as I've been struggling to repro the issue on demand.

It could be a combination of changing project references + paket update that somehow changes the order of the references?

I just looked through the history of this file, a sortBy PATH was added on July 10 (fd3c3ac), and removed on August 12 (e580b8f). Do you know if that was intentional?

@flin-8

flin-8 commented Jan 7, 2017

Copy link
Copy Markdown
Contributor Author

Here's a sample of a diff from before
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants