Skip to content

Change project file condition handling to be case-insensitive #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 4 commits into from
Aug 26, 2016
Merged

Change project file condition handling to be case-insensitive #1890

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6eb9408
Adjust project file condition handling to be case-insensitive
allykzam Aug 25, 2016
a28e3a0
Try odd capitalization in ``should detect output path for proj file``
allykzam Aug 25, 2016
306077f
Adjust output path test to convert results to lowercase first
allykzam Aug 25, 2016
0ddc394
Use OrdinalIgnoreCase in project file condition handling
allykzam Aug 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try odd capitalization in should detect output path for proj file 
Test fails currently because output path detected does not match
configuration name perfectly
  • Loading branch information
@allykzam
allykzam committed Aug 25, 2016
commit a28e3a0bab6903cebf236535ddbb9734900f93a5
2 changes: 1 addition & 1 deletion tests/Paket.Tests/ProjectFile/OutputSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ let ``should detect target framework for Project2 proj file``() =
[<Test>]
let ``should detect output path for proj file``
([<Values("Project1", "Project2", "Project3", "ProjectWithConditions")>] project)
([<Values("Debug", "Release")>] configuration) =
([<Values("Debug", "Release", "dEbUg", "rElEaSe")>] configuration) =
ensureDir ()
ProjectFile.TryLoad(sprintf "./ProjectFile/TestData/%s.fsprojtest" project).Value.GetOutputDirectory configuration ""
|> shouldEqual (System.IO.Path.Combine(@"bin", configuration) |> normalizePath)
Expand Down