Skip to content

Async cache fix in multi-thread-environment for GitHub downloads #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 5 commits into from
Aug 25, 2016
Merged

Async cache fix in multi-thread-environment for GitHub downloads #1880

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3f81e3
Async cache fix in multi-thread-environment for GitHub downloads
Thorium Aug 24, 2016
78e5fd9
Smaller closure signature capture.
Thorium Aug 24, 2016
64c5f59
General function with decent unit test!
Thorium Aug 25, 2016
2d4b05e
minor code cleanup
Thorium Aug 25, 2016
44fd4ba
Unit test proofs that lazy is not needed, but Task serialization defi…
Thorium Aug 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Async cache fix in multi-thread-environment for GitHub downloads
  • Loading branch information
@Thorium
Thorium committed Aug 24, 2016
commit a3f81e335a6bbaa0ebf731f9c6c31a160b58c2d2
14 changes: 7 additions & 7 deletions src/Paket.Core/RemoteDownload.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ open Paket.Domain
open Paket.Git.CommandHelper
open Paket.Git.Handling

let private githubCache = System.Collections.Concurrent.ConcurrentDictionary<_, _>()
let private githubCache = System.Collections.Concurrent.ConcurrentDictionary<_, System.Threading.Tasks.Task<_>>()

let private lookupDocument (auth,url : string) = async {
let key = auth,url
match githubCache.TryGetValue key with
| true, document -> return document
| _ ->
let! document = safeGetFromUrl(auth, url, null)
githubCache.TryAdd(key, document) |> ignore
return document
let fetch = githubCache.GetOrAdd(key, fun key ->
let threadfix = lazy(
safeGetFromUrl(auth, url, null)
|> Async.StartAsTask |> box)
threadfix.Force() |> unbox)
return! fetch |> Async.AwaitTask
}

let private auth key url =
Expand Down