Don't allow empty string as description - take II - #1831

FYI, this has broken our builds. Probably intentionally, but still!

I can revert if that makes sense

Hi - for now I've pinned our build to use 3.9.1, was more just an informational / warning note to others :-)

I reverted it. and releases 3.9.2 is in progress.

@inosik I think we should raise a warning instead.

Sorry for the inconvenience, @richard-green, but I think this change is needed. Packages with any of id, version, authors or description, missing, are practically unusable outside of Paket. That's every tool which uses NuGet.Core, that being NuGet command line, NuGet server, Klondike, Squirrel, Octopus Deploy and Visual Studio. Probably some more.

@biehlermi and I had a hard time figuring out why NuGet based test adapters didn't work in a project of ours. The reason was a package created with Paket, which broke VSs discovery process.

See also themotleyfool/Klondike#158.

@forki, I would rather let Paket fail, because a warning message is easily overseen in the output of a build script. It also clearly indicates the cause of the failure, instead of an error later in the process, like in themotleyfool/Klondike#158. But I also agree that this is kind of breaking.

We could still give it a default description generated from the id and
raise a warning. This would be a soft fix and just silently repair stuff

On Jul 25, 2016 8:04 PM, "Ilja Nosik" notifications@github.com wrote:

@forki https://github.com/forki, I would rather let Paket fail, because
a warning message is easily overseen in the output of a build script. It
also clearly indicates the cause of the failure, instead of an error later
in the process, like in themotleyfool/Klondike#158
https://github.com/themotleyfool/Klondike/issues/158. But I also agree
that this is kind of breaking.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1831 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNN8roYEQgECqq56D-VOVvmmz-de3ks5qZPqUgaJpZM4JUHLP
.

#1833

As @inosik mentioned in https://github.com/themotleyfool/Klondike/issues/158, description is an obligatory field. I'm not a friend of soft fixes. They are almost always a pitfall for anyone who does not know about this.
By the way. We use a paket on a build server. As far as there is no error, nobody ever cares about log files from builds.