Skip to content

Add condition to AfterBuild target to unbreak nCrunch - #1734

Merged
forki merged 2 commits into
fsprojects:masterfrom
thinkbeforecoding:master
Jun 16, 2016
Merged

forki merged 2 commits into
fsprojects:masterfrom
thinkbeforecoding:master

Conversation

@thinkbeforecoding

Copy link
Copy Markdown
Contributor

NCrunch doesn't run well with the target that is generated with some projects.
Adding a condition to the target disable it when running under ncrunch, avoiding to break compilation.

@smoothdeveloper

Copy link
Copy Markdown
Contributor

@thinkbeforecoding could you add a failing (without the change) integration test as well?

Thanks!

@forki

forki commented Jun 16, 2016

Copy link
Copy Markdown
Member

there is actually already a broken test. so @thinkbeforecoding can you please try to fix that one?

@forki
forki merged commit d7dc283 into fsprojects:master Jun 16, 2016
@thinkbeforecoding

Copy link
Copy Markdown
Contributor Author

I'm discovering the IntegrationTests so I'll try to see where it breaks

@forki

forki commented Jun 16, 2016

Copy link
Copy Markdown
Member

I'm already on it
On Jun 16, 2016 4:42 PM, "Jérémie Chassaing" notifications@github.com
wrote:

I'm discovering the IntegrationTests so I'll try to see where it breaks

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1734 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNAhbIONr1W_4jZ_LOvFe5qsyjiM_ks5qMWDSgaJpZM4I3XZo
.

@thinkbeforecoding

Copy link
Copy Markdown
Contributor Author

I think it's in a test where the condition has been added and the test verify equality with exising project. The project should then be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants