Skip to content

Refactoring Bootstrapper to introduce better coverage and testing #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 29 commits into from
Apr 17, 2016
Merged

Refactoring Bootstrapper to introduce better coverage and testing #1603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
1d08ebc
cleanup of unused method
Stift Mar 31, 2016
9aec6af
create tests for CacheDownloadStrategy (bootstrapper)
Stift Mar 31, 2016
084a65b
rearranging files for better overview (bootstrapper)
Stift Mar 31, 2016
f488bcb
added tests for download strategy determination
Stift Apr 3, 2016
a3bc96a
move strategy test
Stift Apr 3, 2016
c128284
create tests for GitHubDownloadStrategy and refactored it
Stift Apr 3, 2016
1a26b19
added test for NugetDownloadStrategy
Stift Apr 4, 2016
6c64848
added tests for NugetApiHelper
Stift Apr 4, 2016
653ea62
added test for SemVer
Stift Apr 4, 2016
63133e9
refactor method with wrong responseStream handling
Stift Apr 4, 2016
2771ae9
Merge remote-tracking branch 'fsprojects/master' into bootstrapUpdate…
Stift Apr 7, 2016
fa39b9e
refactored argument parsing and created test for argument parsing
Stift Apr 7, 2016
f65ac2e
added tests for StartPaketBootstrapping
Stift Apr 8, 2016
54e3bd6
create some additional tests for ArgumentParser
Stift Apr 8, 2016
43bf687
removed fallback logic from CachedDownload strategy as this is alread…
Stift Apr 8, 2016
82fb98d
added test on Name of CacheDownloadStrategyTest
Stift Apr 8, 2016
7f9a01c
improve argument parsing
Stift Apr 11, 2016
4ef6965
Merge commit '0a917114f993b3e3b9917a208c768273b42ee87f' into bootstra…
Stift Apr 11, 2016
cbb9683
fix deprecated assert after nunit3 introduction
Stift Apr 11, 2016
19b601f
refactored console logging to use centrally one implementation and al…
Stift Apr 12, 2016
e00d077
Merge commit 'fbeb48803e5084216f7c4c6505d50ad7a5005d67' into bootstra…
Stift Apr 12, 2016
084d31b
fixing non-compiling tests
Stift Apr 12, 2016
57e0354
add help output to bootstrapper
Stift Apr 12, 2016
9dabe0d
fix bug when downloading latest but prerelease is already in directory
Stift Apr 12, 2016
da63dd9
optimize code
Stift Apr 12, 2016
84f421a
remove unused code
Stift Apr 12, 2016
5c821df
add test for non cached strategy resolving
Stift Apr 12, 2016
60cc032
add --help option to documentation
Stift Apr 12, 2016
dc9e256
removed code commented out and missed to remove
Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rearranging files for better overview (bootstrapper)
  • Loading branch information
@Stift
Stift committed Mar 31, 2016
commit 084a65b408cc008be368bfddada89546f24e4fd8
3 changes: 2 additions & 1 deletion ...ket.Bootstrapper/CacheDownloadStrategy.cs → ...wnloadStrategies/CacheDownloadStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
using System.IO;
using System.Linq;
using System.Net;
using Paket.Bootstrapper.HelperProxies;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.DownloadStrategies
{
internal class CacheDownloadStrategy : IDownloadStrategy
{
Expand Down
2 changes: 1 addition & 1 deletion ...et.Bootstrapper/GitHubDownloadStrategy.cs → ...nloadStrategies/GitHubDownloadStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Net;
using System.Reflection;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.DownloadStrategies
{
internal class GitHubDownloadStrategy : IDownloadStrategy
{
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/IDownloadStrategy.cs → ...r/DownloadStrategies/IDownloadStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.Net;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.DownloadStrategies
{
public interface IDownloadStrategy
{
Expand Down
2 changes: 1 addition & 1 deletion ...ket.Bootstrapper/NugetDownloadStrategy.cs → ...wnloadStrategies/NugetDownloadStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.Net;
using System.Reflection;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.DownloadStrategies
{
internal class NugetDownloadStrategy : IDownloadStrategy
{
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/DirectoryProxy.cs → ...tstrapper/HelperProxies/DirectoryProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Collections.Generic;
using System.IO;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.HelperProxies
{
internal class DirectoryProxy : IDirectoryProxy
{
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/FileProxy.cs → ...t.Bootstrapper/HelperProxies/FileProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.IO;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.HelperProxies
{
class FileProxy : IFileProxy
{
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/IDirectoryProxy.cs → ...strapper/HelperProxies/IDirectoryProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.Collections.Generic;

namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.HelperProxies
{
public interface IDirectoryProxy
{
Expand Down
2 changes: 1 addition & 1 deletion src/Paket.Bootstrapper/IFileProxy.cs → ....Bootstrapper/HelperProxies/IFileProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Paket.Bootstrapper
namespace Paket.Bootstrapper.HelperProxies
{
public interface IFileProxy
{
Expand Down
16 changes: 8 additions & 8 deletions src/Paket.Bootstrapper/Paket.Bootstrapper.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@
</ItemGroup>
<ItemGroup>
<Compile Include="BootstrapperHelper.cs" />
<Compile Include="CacheDownloadStrategy.cs" />
<Compile Include="DirectoryProxy.cs" />
<Compile Include="DownloadStrategies\CacheDownloadStrategy.cs" />
<Compile Include="HelperProxies\DirectoryProxy.cs" />
<Compile Include="DownloadArguments.cs" />
<Compile Include="EnvProxy.cs" />
<Compile Include="FileProxy.cs" />
<Compile Include="GitHubDownloadStrategy.cs" />
<Compile Include="IDirectoryProxy.cs" />
<Compile Include="IDownloadStrategy.cs" />
<Compile Include="IFileProxy.cs" />
<Compile Include="NugetDownloadStrategy.cs" />
<Compile Include="HelperProxies\FileProxy.cs" />
<Compile Include="DownloadStrategies\GitHubDownloadStrategy.cs" />
<Compile Include="HelperProxies\IDirectoryProxy.cs" />
<Compile Include="DownloadStrategies\IDownloadStrategy.cs" />
<Compile Include="HelperProxies\IFileProxy.cs" />
<Compile Include="DownloadStrategies\NugetDownloadStrategy.cs" />
<Compile Include="Program.cs" />
<Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="SemVer.cs" />
Expand Down
2 changes: 2 additions & 0 deletions src/Paket.Bootstrapper/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
using System.Net;
using System.Reflection;
using System.Runtime.CompilerServices;
using Paket.Bootstrapper.DownloadStrategies;
using Paket.Bootstrapper.HelperProxies;

[assembly: InternalsVisibleTo("Paket.Bootstrapper.Tests")]

Expand Down
2 changes: 2 additions & 0 deletions tests/Paket.Bootstrapper.Tests/CacheDownloadStrategyTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
using System.Net;
using Moq;
using NUnit.Framework;
using Paket.Bootstrapper.DownloadStrategies;
using Paket.Bootstrapper.HelperProxies;

namespace Paket.Bootstrapper.Tests
{
Expand Down