Skip to content

Remove --hard flag - #1567

Merged
forki merged 3 commits into
v3from
reallyhard
Apr 5, 2016
Merged

Remove --hard flag#1567
forki merged 3 commits into
v3from
reallyhard

Conversation

@forki

@forki forki commented Apr 4, 2016

Copy link
Copy Markdown
Member

Background

--hard: Replaces package references within project files 
          even if they are not yet adhering to the Paket's conventions 
          (and hence considered manually managed).

Sample

in default mode paket 2.0 will not change references to libraries if they are not already controlled by paket. A common case is "file/ enw F# project" creates a fsproj file that already references FSharp.Core. If you then add FSharp.Core as nuget package, then Paket will not replace the reference unless you specify --hard parameter.

Suggestion

I suggest we remove the --hard flag in paket v3 and thread all calls as if --hard would have been set.

  • removed flag from all commands
  • fixed tests
  • update docs

We will not create a --soft flag to restore old behaviour, but if you really need to keep that existing reference you can manually add a

<paket>false</paket>

@forki

forki commented Apr 4, 2016

Copy link
Copy Markdown
Member Author

This is obviously breaking, but it was a big source for confusion.

I'm only suggesting this for v3 so I'm relaxed about it like this guy:

pizza

@isaacabraham

isaacabraham commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

This is good, it's what I think people expect anyway as the default.

@tsibelman

tsibelman commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

It fine to remove it in my opinion. But what would happen if I try to use it ? Will I gen an error or it just will be ignored ? I prefer not to have an error, this way I don't need to update my scripts.

@forki

forki commented Apr 4, 2016

Copy link
Copy Markdown
Member Author

With this pr we would throw an error: unknown parameter --hard
On Apr 4, 2016 8:28 PM, "tsibelman" notifications@github.com wrote:

It fine to remove it in my opinion. But what would happen if I try to use
it ? Will I gen an error or just it will be ignored ? I prefer not to have
an error this way I don't need to update my scripts.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1567 (comment)

@tsibelman

tsibelman commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

Can this be a warning instead ?

@forki

forki commented Apr 4, 2016

Copy link
Copy Markdown
Member Author

Since this is a major release change I would prefer not to take that debt.
On Apr 4, 2016 8:43 PM, "tsibelman" notifications@github.com wrote:

Can this be a warning instead ?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1567 (comment)

@isaacabraham

isaacabraham commented Apr 5, 2016

Copy link
Copy Markdown
Contributor

Agree with @forki - this a major release with a breaking change that should be documented as part of the release.

@forki
forki merged commit 3e43fbd into v3 Apr 5, 2016
@forki
forki deleted the reallyhard branch April 5, 2016 12:27
@forki forki mentioned this pull request May 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forki @isaacabraham @tsibelman