Skip to content

Property Definitions: placed after non-paket imports if they directly follow the top property groups - #1561

Merged
forki merged 2 commits into
fsprojects:masterfrom
cdrnet:project-propdefs-after-propgroupsimports
Mar 30, 2016
Merged

Property Definitions: placed after non-paket imports if they directly follow the top property groups#1561
forki merged 2 commits into
fsprojects:masterfrom
cdrnet:project-propdefs-after-propgroupsimports

Conversation

@cdrnet

@cdrnet cdrnet commented Mar 30, 2016

Copy link
Copy Markdown
Member

Related to #1537

If in a project file there are non-paket imports right after the top property groups, then place the property definitions right after them (instead of before them). This makes sure that imports like Microsoft.CSharp.targets can be moved up before them, to make sureTargetFrameworkIdentifier is actually defined. Note that it does not move Microsoft.CSharp.targets up manually if it is further down (which it is by default).

@cdrnet

cdrnet commented Mar 30, 2016

Copy link
Copy Markdown
Member Author

Should I rather have created/forked a new integration test instead of changing existing ones?

@forki

forki commented Mar 30, 2016

Copy link
Copy Markdown
Member

Yeah more tests are probably better
On Mar 30, 2016 10:40 AM, "Christoph Ruegg" notifications@github.com
wrote:

Should I rather have created/forked a new integration test instead of
changing existing ones?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1561 (comment)

@forki forki mentioned this pull request Mar 30, 2016
Closed
@forki

forki commented Mar 30, 2016

Copy link
Copy Markdown
Member

but I think it's fine

@forki
forki merged commit 17c07bb into fsprojects:master Mar 30, 2016
@cdrnet

cdrnet commented Mar 30, 2016

Copy link
Copy Markdown
Member Author

Note that in the quite common case that Microsoft.CSharp.targets is further down this change will only allow to manually fix it by moving it up (and make the fix survive paket operations), but will not actually fix it itself.

Should we try to be smarter? Being smart could easily break other stuff unfortunately.

@forki

forki commented Mar 30, 2016

Copy link
Copy Markdown
Member

I think we should wait and see what happens - also in regards to #1562

@cdrnet cdrnet mentioned this pull request Mar 30, 2016
Closed
@cdrnet
cdrnet deleted the project-propdefs-after-propgroupsimports branch March 30, 2016 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdrnet @forki