Skip to content

Fixing problem with @ char in paths during pack (#1348) - #1351

Merged
forki merged 2 commits into
fsprojects:masterfrom
Vidarls:foldernames
Jan 6, 2016
Merged

forki merged 2 commits into
fsprojects:masterfrom
Vidarls:foldernames

Conversation

@Vidarls

@Vidarls Vidarls commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

ref: #1348

@forki

forki commented Jan 6, 2016

Copy link
Copy Markdown
Member

the travis fail is unrelated.
thx

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@Vidarls

Vidarls commented Jan 6, 2016

Copy link
Copy Markdown
Contributor Author

ok, good. Was scratching my head severely now

@Vidarls

Vidarls commented Jan 6, 2016

Copy link
Copy Markdown
Contributor Author

Quick question, what is the logic behind the # 1234 type naming in the integration tests? I just did the above test number +1, but now I am starting to think it might be references to github issues?

@forki

forki commented Jan 6, 2016

Copy link
Copy Markdown
Member

yep test name should be "#1348 ..."

@forki

forki commented Jan 6, 2016

Copy link
Copy Markdown
Member

this allows us to find the issue from the test (when we break it in the future)

@Vidarls

Vidarls commented Jan 6, 2016

Copy link
Copy Markdown
Contributor Author

fixing...

@Vidarls

Vidarls commented Jan 6, 2016

Copy link
Copy Markdown
Contributor Author

fixed

forki added a commit that referenced this pull request Jan 6, 2016
Fixing problem with @ char in paths during pack (#1348)
@forki
forki merged commit 5a25871 into fsprojects:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants