Skip to content

ConfigFile: password encryption does not work on specific machine con… - #1347

Merged
forki merged 3 commits into
fsprojects:masterfrom
haraldsteinlechner:master
Jan 5, 2016
Merged

forki merged 3 commits into
fsprojects:masterfrom
haraldsteinlechner:master

Conversation

@haraldsteinlechner

Copy link
Copy Markdown
Contributor

This pull request solves issue #1346

Note that i did not change DataProtectionScopes for decryption. This is is the minimal change i know which works (i think decrpytion ignores this).
The docs do not say anything about this: e.g. https://msdn.microsoft.com/en-us/library/2fh8203k(v=vs.110).aspx

…figurations. This is the minimal fix to make password encryption work in our environment. seealso issue: fsprojects#1346
@forki

forki commented Jan 5, 2016

Copy link
Copy Markdown
Member

mhm this doesn't work on travis!?

@haraldsteinlechner

Copy link
Copy Markdown
Contributor Author

ah ok. awesome. no solution works on all configurations. We could do a simple probing - handle exception and try in local machine mode if user mode fails. what you think?

@forki

forki commented Jan 5, 2016

Copy link
Copy Markdown
Member

sounds good. whatever works to make it work for more people is fine

… user encryption scope and local machine if attempt fails)
@haraldsteinlechner

Copy link
Copy Markdown
Contributor Author

works now

Comment thread src/Paket.Core/ConfigFile.fs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a verbosefn might be enough here

forki added a commit that referenced this pull request Jan 5, 2016
ConfigFile: password encryption does not work on specific machine con…
@forki
forki merged commit af7bb6f into fsprojects:master Jan 5, 2016
@forki

forki commented Jan 5, 2016

Copy link
Copy Markdown
Member

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants