Skip to content

Update ProjectFile.GetTargetProfile to work with conditional nodes #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 7 commits into from
Nov 16, 2015
Merged

Update ProjectFile.GetTargetProfile to work with conditional nodes #1227

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ce2432
Add GetProperty member to ProjectFile type
allykzam Nov 16, 2015
e756a1a
Adjust ProjectFile.GetProperty to not require default values
allykzam Nov 16, 2015
1b02825
Use GetProperty from ProjectFile.GetTargetFrameworkIdentifier
allykzam Nov 16, 2015
b905c75
Use GetProperty from ProjectFile.GetTargetFrameworkProfile
allykzam Nov 16, 2015
3220a25
Use GetProperty from GetTargetProfile when a profile isn't explictly set
allykzam Nov 16, 2015
73e6f8c
Add a conditional TargetFramework{Version,Profile} to test file
allykzam Nov 16, 2015
9ef7828
Add test for TargetFrameworkProfile detection
allykzam Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a conditional TargetFramework{Version,Profile} to test file 
in ProjectWithConditions.fsprojtest
  • Loading branch information
@allykzam
allykzam committed Nov 16, 2015
commit 73e6f8c686ca5a26fd9a7decee82435cad929daf
4 changes: 2 additions & 2 deletions tests/Paket.Tests/ProjectFile/TestData/ProjectWithConditions.fsprojtest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
<OutputType>Library</OutputType>
<RootNamespace>Paket.Tests</RootNamespace>
<AssemblyName>Paket.Tests</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<TargetFrameworkVersion Condition="'$(TargetFrameworkVersion)' == ''">v4.6</TargetFrameworkVersion>
<TargetFrameworkProfile Condition="'$(TargetFrameworkVersion)' == 'v4.0'">Client</TargetFrameworkProfile>
<TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>
<Name>Paket.Tests</Name>
<TargetFrameworkProfile />
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
<RestorePackages>true</RestorePackages>
</PropertyGroup>
Expand Down