Skip to content

try to cache proxy - #1153

Merged
forki merged 11 commits into
masterfrom
proxy
Oct 21, 2015
Merged

forki merged 11 commits into
masterfrom
proxy

Conversation

@forki

@forki forki commented Oct 19, 2015

Copy link
Copy Markdown
Member

for a couple of users it seems to be very very slow to calc the proxy. see https://gitter.im/fsprojects/Paket discussion with @alexeyzimarev

@forki

forki commented Oct 19, 2015

Copy link
Copy Markdown
Member Author

//cc @vasily-kirichenko could you please take a look?

@vasily-kirichenko

Copy link
Copy Markdown
Contributor

Looks like an ordinary thread safe memoization. Maybe it is worth to extract memoze into some core module.

@forki

forki commented Oct 19, 2015

Copy link
Copy Markdown
Member Author

the question is more: do you think it's enough to cache proxy per HTTP host?

@vasily-kirichenko

Copy link
Copy Markdown
Contributor

No idea.

@forki

forki commented Oct 19, 2015

Copy link
Copy Markdown
Member Author

fair enough ;-)

@forki

forki commented Oct 19, 2015

Copy link
Copy Markdown
Member Author

I released this as 2.16.0-alpha001.
ypu can get it with paket.bootstrapper.exe prerelease

@alexeyzimarev, @alistair please check if it improves things

@vasily-kirichenko could you please verify that we don't break you

thanks everbody.

@forki

forki commented Oct 19, 2015

Copy link
Copy Markdown
Member Author

@dnauck you are also behind proxy, right?

@alexeyzimarev

Copy link
Copy Markdown

I am at home now and have no proxy. Will be able to check tomorrow if I would reach my machine at work, I will be at another office for three days.

@alistair

Copy link
Copy Markdown

So I have just updated to the latest, cleaned cache and packages directory and run the following

https://gist.github.com/alistair/65cba5d92556e6f0457c

Time taken has dropped from 7 minutes to 1.

@dnauck

dnauck commented Oct 19, 2015

Copy link
Copy Markdown
Contributor

@forki no .. not with my dev machine, cannot test

Most commercial proxy solutions have virus checking, so the first download and unzip of nuget packages for virus check could take a long time. If the package is too large or contains to many files it could also fail.

forki added 8 commits October 20, 2015 11:52
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
@forki
forki merged commit 7c6748d into master Oct 21, 2015
@alexeyzimarev

Copy link
Copy Markdown

I tested with 2.16.0 and it works splendidly 👍 46 seconds instead of seven minutes.

@forki

forki commented Oct 23, 2015

Copy link
Copy Markdown
Member Author

Awesome. Thanks for all the help here.

@vasily-kirichenko

Copy link
Copy Markdown
Contributor

Tested paket outdated on 2.16.0. Works OK, but I'm not sure it's faster.

@forki

forki commented Oct 23, 2015

Copy link
Copy Markdown
Member Author

It's only faster for a handful of people where the proxy detection was
super slow. Most people (like myself) will not have perf gains. But I was
worried that caching might break things.
On Oct 23, 2015 8:55 AM, "Vasily Kirichenko" notifications@github.com
wrote:

Tested paket outdated on 2.16.0. Works OK, but I'm not sure it's faster.

—
Reply to this email directly or view it on GitHub
#1153 (comment).

@matthid
matthid deleted the proxy branch May 6, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants