Skip to content

Warn about pinned packages only when a new version is available #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 7 commits into from
Aug 27, 2015
Merged

Warn about pinned packages only when a new version is available #1014

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ab7a7c
Moving the pinned warning block next to availableVersions
mrinaldi Aug 25, 2015
6227890
Fetches versions for all packages, including pinned
mrinaldi Aug 25, 2015
4b90978
Warns only when the pinned package has a new version available
mrinaldi Aug 25, 2015
4bb2db3
Does not filter prerelease versions when pinned version is prerelease
mrinaldi Aug 25, 2015
a115a8c
Does not filter prerelease versions when requirement accepts prereleases
mrinaldi Aug 25, 2015
aad7c9c
Does not warn about pinned packages in install mode
mrinaldi Aug 25, 2015
c59ed4e
Creating UpdateMode discriminated union
mrinaldi Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Moving the pinned warning block next to availableVersions
  • Loading branch information
@mrinaldi
mrinaldi committed Aug 25, 2015
commit 9ab7a7c661894f0b4c45f7e85c606ff006bb2cbf
31 changes: 16 additions & 15 deletions src/Paket.Core/PackageResolver.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,21 +223,6 @@ let Resolve(getVersionsF, getPackageDetailsF, globalFrameworkRestrictions, rootD
package
| _ -> package
| false,_ ->
let getPinnedVersion d =
match d.Parent with
| DependenciesFile _ ->
match d.VersionRequirement.Range with
| Specific v -> Some v
| OverrideAll v -> Some v
| _ -> None
| Package _ -> None
requirements
|> Set.filter (fun r -> NormalizedPackageName dependency.Name = NormalizedPackageName r.Name)
|> Set.map getPinnedVersion
|> Seq.choose id
|> Seq.tryHead
|> Option.iter (traceWarnfn " %O is pinned to version %O" dependency.Name)

tracefn " - %s %A" name version
let packageDetails : PackageDetails = getPackageDetailsF dependency.Sources dependency.Name version
let restrictedDependencies = DependencySetFilter.filterByRestrictions (dependency.Settings.FrameworkRestrictions @ globalFrameworkRestrictions) packageDetails.DirectDependencies
Expand Down Expand Up @@ -325,6 +310,22 @@ let Resolve(getVersionsF, getPackageDetailsF, globalFrameworkRestrictions, rootD
|> Seq.fold (&&) ((map currentRequirement).VersionRequirement.IsInRange(ver))

availableVersions := getAllVersions(currentRequirement.Sources,currentRequirement.Name,currentRequirement.VersionRequirement.Range)

let getPinnedVersion d =
match d.Parent with
| DependenciesFile _ ->
match d.VersionRequirement.Range with
| Specific v -> Some v
| OverrideAll v -> Some v
| _ -> None
| Package _ -> None
requirements
|> Set.filter (fun r -> NormalizedPackageName currentRequirement.Name = NormalizedPackageName r.Name)
|> Set.map getPinnedVersion
|> Seq.choose id
|> Seq.tryHead
|> Option.iter (traceWarnfn " %O is pinned to version %O" currentRequirement.Name)

compatibleVersions := List.filter (isInRange id) (!availableVersions)
if currentRequirement.VersionRequirement.Range.IsGlobalOverride then
globalOverride := true
Expand Down