Convert-from-nuget & .targets  #776

Activity

1. petarvucetin

   changed the title [-]Conver-from-nuget & .targets [/-] [+]Convert-from-nuget & .targets [/+] on Apr 14, 2015
2. forki commented on Apr 14, 2015

   

   forki

   on Apr 14, 2015

   Member

   More actions

   yes that true. we currently don't remove such imports.

   @theimowski
3. petarvucetin commented on Apr 14, 2015

   

   petarvucetin

   on Apr 14, 2015

   Author

   More actions

   And there is more junk that some packages install...

   <Import Project="..\Solution Files\packages\PostSharp.4.1.8-beta\tools\PostSharp.targets" Condition="Exists('..\Solution Files\packages\PostSharp.4.1.8-beta\tools\PostSharp.targets')" />
   <Target Name="EnsurePostSharpImported" BeforeTargets="BeforeBuild" Condition="'$(PostSharp30Imported)' == ''">
       <Error Condition="!Exists('..\Solution Files\packages\PostSharp.4.1.8-beta\tools\PostSharp.targets')" Text="This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://www.postsharp.net/links/nuget-restore." />
        <Error Condition="Exists('..\Solution Files\packages\PostSharp.4.1.8-beta\tools\PostSharp.targets')" Text="The build restored NuGet packages. Build the project again to include these packages in the build. For more information, see http://www.postsharp.net/links/nuget-restore." />
    </Target>
   
4. theimowski commented on Apr 14, 2015

   

   theimowski

   on Apr 14, 2015

   Member

   More actions

   This might be not trivial to detect. Need to find a way how to recognize all such entries
5. forki commented on Apr 14, 2015

   

   forki

   on Apr 14, 2015

   Member

   More actions

   Yep that's the big issue. We can't reliably detect this. But maybe we can
   have heuristic that will work for most important packages.
   On Apr 14, 2015 9:01 PM, "Tomasz Heimowski" notifications@github.com
   wrote:

   This might be not trivial to detect. Need to find a way how to recognize
   all such entries

   —
   Reply to this email directly or view it on GitHub
   #776 (comment).
6. petarvucetin commented on Apr 14, 2015

   

   petarvucetin

   on Apr 14, 2015

   Author

   More actions

   From what I have seen in my csproj files these always follow each other <Import> then <Target> if that helps.
7. theimowski

   added a commit that references this issue on Apr 21, 2015

   remove custom import and targets - references fsprojects#776

   ca8bea9
8. theimowski commented on Apr 23, 2015

   

   theimowski

   on Apr 23, 2015

   Member

   More actions

   @petarvucetin can you verify that with the newest version?
9. theimowski

   closed this as completedon Apr 27, 2015