You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Paket downgrades direct dependency without reason #3103
Paket resolves a direct dependency to a lower version than available, even though the latest version is also a valid resolution, with the same transitive dependency solution.
I would really like to give a reproduction sample here, but unfortunately, I only had this bug happen using our internal artifact server and packages. Instead, please try to follow my reasoning through this log, which is the result of running paket update -v on a paket.dependencies file with a single (nuget) entry : delphi-tf-latest-convert: https://gist.github.com/auxym/5b87b8cd92ab80b75a68addf65492e68
Here is what I understand is happening:
L43: The latest available version of delphi-tf-latest-convert is found from the feed: 0.0.75. This is the desired version.
L91. We resolved an additional transitive dependency : Taxdoc, to the latest available. So far so good.
L153 This is where things get weird. Since L91, paket found a conflict in the dependencies of taxdoc and latest-calc. To fix this, it decided to downgrade our direct dependency, delphi-tf-latest-convert, to 0.0.74. This is even though the transitive dependencies of 0.0.74 and 0.0.75 are absolutely identical.
L332 Final resolution solution: we have delphi-tf-latest-convert v 0.0.74, even though the latest version (0.0.75), would be valid with the exact same resolution.
Repro steps
See above, unfortunately I cannot provide a repro example using external projects.
Expected behavior
Given a valid solution to version resolution, I would expect our direct dependencies to be resolved to the highest possible version.
Actual behavior
Paket seems to always resolve to exactly one version behind.
Known workarounds
Right now, taxdoc is resolved first (see step 2 above). I understand that this is because of alphabetical order, as none of the transitive dependencies have any version constraint on them (from what I understand of Paket Resolution Algorithm).
We are working around the issue by adding a very loose version constraint to tf-latest-calc, which forces paket to attempt resolving it first, before TaxDoc. This results in correctly resolving delphi-tf-latest-convert to the latest version (0.0.75).
I openend #3104 with a start for a unittest that nails down your case. Please take a look and extent the graph until it breaks like you see in the real world case
Activity
try to help reproducing #3103
forki commentedon Mar 9, 2018
I openend #3104 with a start for a unittest that nails down your case. Please take a look and extent the graph until it breaks like you see in the real world case
auxym commentedon Mar 9, 2018
Thanks, I'll try setting up something that reproduces the issue.
auxym commentedon Mar 9, 2018
OK, I created #3106 which is based on #3104 and reproduces the exact same issue we get.
For additional fun, try adding additional versions of
delphi-tf-latest-convertto the graph. Paket always resolves one version prior to latest :)forki commentedon Mar 9, 2018
fixes #3103
forki commentedon Mar 9, 2018
it's confirmed as bug
forki commentedon Mar 10, 2018
@auxym I'm working on a fix in #3104 but it's not trivial. Interesting corner case.
Try a faster solution to #3103